search

puniverse / comsat

Fibers and actors for web development
docs.paralleluniverse.co/comsat
Other
598 stars 103 forks source link

Added support for latest jOOQ version #91

Open roded opened 7 years ago

roded commented 7 years ago

Hi, Here's a start. I'm not sure about "comsat-jooq-latest", perhaps "comsat-jooq-java8" is more appropriate. Please let me know of any comments or reservations.

pron commented 7 years ago

Thank you! This looks good, but please change jooq-latest to jooq-java8 as you suggested. Also, take a look at the Quasar build file to see how to exclude subprojects from the build when built using Java 7.

roded commented 7 years ago

No problem. Could you be more explicit regarding the subproject build exclusion? Thanks

roded commented 7 years ago

On my machine, the exclusion of the tests from the sourceSet deletes the test class for some reason, not sure why..

roded commented 7 years ago

@pron Could you review the gradle solution to make sure it's appropriate? Anything else I can do to further this along? Thanks

roded commented 7 years ago

The sources & javadocs artifacts are inherited from the parent build.gradle it seems. Added them explicitly.

roded commented 7 years ago

The comsat-jooq-java8 build and tests seem OK. The reported build error is a test in the okhttp integration. A previous build for the same PR (with no changes to the PR code) failed in WebActorServletTest. I'm not sure if these are related to this PR.