search

punkave / pk-pattern-library

a pattern library generator for ApostropheCMS :pencil:
0 stars 0 forks source link

Removes excess CSS #22

Closed abea closed 5 years ago

abea commented 5 years ago

Moving this since they were overriding my project styles too easily.

grdunn commented 5 years ago

Interesting. Shouldn't be a problem, you'll just be pushing those styles on the real site.

grdunn commented 5 years ago

Sorry, I realized that the skeleton.css file includes a lot of element targeted styling, and worry this could conflict with a lot of project styles. Perhaps #23 would be the right solution, and we can leave the bare bones styles for the pk-pattern-library chrome to exist in extraHead, so we're not pushing it via pushAssets?

abea commented 5 years ago

@grdunn Why don't you want to push it with pushAsset?

grdunn commented 5 years ago

@abea won't that push the styles on every page load?

abea commented 5 years ago

Oh, you're right. That's not ideal.

abea commented 5 years ago

Closes #23

The main thing lost here is the html style since it doesn't go under the body class. Our projects have that in the boilerplate already, though.

abea commented 5 years ago

Bumping this.

grdunn commented 5 years ago

@abea The only thing I would be sad to see go is the Nunito type treatment that was used as the default for the design. I believe this was initially not great, because it set on the body and cascading down. Ideally, we could scope the $pkpl-font-family sass variable to appropriate classes.

There should be classes in the markup to target, ie:

grdunn commented 5 years ago

Ah -- I am seeing this now here:

https://github.com/punkave/pk-pattern-library/pull/22/commits/e08cb0b283f7f75e05cf41cd371f74d5526fda7f#diff-3d43168087ccbfe6d00518d6c889ba7dR12

Edit: Seeing now that was later removed. Heh.