search

punkave / stylelint-config-punkave

0 stars 0 forks source link

Removes font-weight notation #42

Closed abea closed 5 years ago

abea commented 5 years ago

If we're using a weight function then we shouldn't be expecting numeric here.

abea commented 5 years ago

How about we switch it to only a warning severity? If our internal practice is not to use numeric font-weights (instead using the function) then having a rule that font weight should be numeric isn't doing anything for us.

austinstarin commented 5 years ago

One other recommendation would be change the function name get-weight().

abea commented 5 years ago

Would that solve the issue?

bgantick commented 5 years ago

Changing the function name wouldn't solve the issue.

abea commented 5 years ago

So yeah, I think we need to remove the rule or switch it to a warning and live with those. Once the stylelint update happens that could be changed.