search

punker76 / gong-wpf-dragdrop

The GongSolutions.WPF.DragDrop library is a drag'n'drop framework for WPF
BSD 3-Clause "New" or "Revised" License
2.28k stars 400 forks source link

fix touch support #444

Closed dmg-hamann closed 2 years ago

dmg-hamann commented 2 years ago

What changed?

Added the code @KKauK suggested in #418 and enhanced Showcase to test touch. I was able to test on a touch panel and after the adjustments it works fine.

Closes #418

jizc commented 2 years ago

I'm sure this was unintentional, but your PR reverts the changes from #426 and #430. You may want to rebase.

dmg-hamann commented 2 years ago

Oh Im sorry. I'll fix that.

dmg-hamann commented 2 years ago

I made the mistake to use the files mentioned in the issue which were based on an older commit and I replaced the whole content. I merged the code

las-nsc commented 2 years ago

@dmg-hamann @punker76, any chance of getting this in? It's making our solution unusable.

punker76 commented 2 years ago

@las-nsc I am still on holiday. Next week I can have a look at this.

John-Welch commented 2 years ago

(@las-nsc's colleague here) @punker76 Do you have a rough idea when this might be merged and pushed into NuGet? We'd much prefer to pick up an updated package from there than have to fork the repo and apply the PR locally to get the fix for our solution.

punker76 commented 2 years ago

@dmg-hamann your changes have been merged, thanks for your contribution 👍

John-Welch commented 2 years ago

Thanks very much for the fix - I've upgraded to 3.2.0 using NuGet and the propblem has gone away.