punker76 / gong-wpf-dragdrop

The GongSolutions.WPF.DragDrop library is a drag'n'drop framework for WPF
BSD 3-Clause "New" or "Revised" License
2.31k stars 405 forks source link

DropTarget hint and DropHighlightAdorner background brush #489

Open mangoyoga80 opened 8 months ago

mangoyoga80 commented 8 months ago

What changed?

Feature DropTargetHighlightBrush

Feature DropHint

Closed issues.

487 Added drop target hints

488 Added the ability to change the brush of hint adorner.

bsundsbo commented 8 months ago

@punker76 any chance you are able to take a look at this PR in the near future?

Happy Easter

bsundsbo commented 3 months ago

@punker76 any chance you are able to take a look at this PR in the near future?

Happy Easter

@punker76 Hi. I just wanted to follow up on this PR in case you have more time these days :)

punker76 commented 3 months ago

@bsundsbo I will take a look in next days

punker76 commented 2 months ago

Hi @mangoyoga80, I've finally had a look at your changes! I really like the feature. I only have one concern at the moment. Since an adorner is also used here for highlighting, the DropTargetAdorner is now always behind the HighlightAdorner. This cannot be prevented, as in WPF all adorners always get the same zIndex in the AdornerLayer.

2024-09-11_14h13_41

But I already have an idea how we can get this under control. Perhaps I will first adopt your changes and then build my idea on them. But in any case, thanks for your contribution here!!!

/cc @bsundsbo

mangoyoga80 commented 2 months ago

Hi @mangoyoga80, I've finally had a look at your changes! I really like the feature. I only have one concern at the moment. Since an adorner is also used here for highlighting, the DropTargetAdorner is now always behind the HighlightAdorner. This cannot be prevented, as in WPF all adorners always get the same zIndex in the AdornerLayer.

2024-09-11_14h13_41

But I already have an idea how we can get this under control. Perhaps I will first adopt your changes and then build my idea on them. But in any case, thanks for your contribution here!!!

/cc @bsundsbo

I've not seen that issue as I've not used similar scenarios. Great you have some ideas how to fix. Glad you like the feature