Open mangoyoga80 opened 8 months ago
@punker76 any chance you are able to take a look at this PR in the near future?
Happy Easter
@punker76 any chance you are able to take a look at this PR in the near future?
Happy Easter
@punker76 Hi. I just wanted to follow up on this PR in case you have more time these days :)
@bsundsbo I will take a look in next days
Hi @mangoyoga80, I've finally had a look at your changes! I really like the feature. I only have one concern at the moment. Since an adorner is also used here for highlighting, the DropTargetAdorner is now always behind the HighlightAdorner. This cannot be prevented, as in WPF all adorners always get the same zIndex in the AdornerLayer.
But I already have an idea how we can get this under control. Perhaps I will first adopt your changes and then build my idea on them. But in any case, thanks for your contribution here!!!
/cc @bsundsbo
Hi @mangoyoga80, I've finally had a look at your changes! I really like the feature. I only have one concern at the moment. Since an adorner is also used here for highlighting, the DropTargetAdorner is now always behind the HighlightAdorner. This cannot be prevented, as in WPF all adorners always get the same zIndex in the AdornerLayer.
But I already have an idea how we can get this under control. Perhaps I will first adopt your changes and then build my idea on them. But in any case, thanks for your contribution here!!!
/cc @bsundsbo
I've not seen that issue as I've not used similar scenarios. Great you have some ideas how to fix. Glad you like the feature
What changed?
DropTargetAdorner
with null check and some base propertiesFeature DropTargetHighlightBrush
dd:DragDrop.DropTargetHighlightBrush
.Feature DropHint
dd:DragDrop.UseDropTargetHint
to enable the featuredd:DragDrop.DropHintDataTemplate
to override datatemplate for displaying hintDragDrop.TryGetDropHandler
andDragDrop.TryGetDropInfoBuilder
internalIDropTarget.DropHint
and new properties onIDropInfo
which may be breaking changedd:DragDrop.UseDropTargetHint
added in SettingsView to enable for all demos using these settingsClosed issues.
487 Added drop target hints
488 Added the ability to change the brush of hint adorner.