Current procedure seems overly complicated

punksta / volume_control_android

noads/free volume controll application

https://play.google.com/store/apps/details?id=com.punksta.apps.volumecontrol

MIT License

55 stars 18 forks source link

Current procedure seems overly complicated #9

Closed uli-on closed 5 years ago

uli-on commented 5 years ago

We currently have two independent fields with slider controls when we create profiles. Why not use the current settings, simply adjust these, and create new profiles of these settings?

Advantages:

No inadverted sound level surprises (by sliders being fully opened like ATM)
Less confusing interface
Quicker adjusting of existing settings
Less sliders to have an eye on
(Maybe even less code?)

punksta commented 5 years ago

added in https://github.com/punksta/volume_control_android/commit/841b8506cae54808d625935e108c489da1a362bb will be delivered in next release.

Thanks for a good idea!

uli-on commented 5 years ago

Thanks for integrating the idea, but this one doesn't work yet. Saving a profile does copy over the settings to the new dialog, but applying such a saved profile turns up the volumes on all available sliders to full!!

That might harm some ears, especially when trying to finetune a profile for getting to sleep, like my own attempt ;)

Edit: spelling, clarification

punksta commented 5 years ago

@uli-on oh no, such a annoying bug. I will sent a hot fix release today/tomorrow.

punksta commented 5 years ago

fixed in https://github.com/punksta/volume_control_android/releases/tag/2.2.4