punktDe / form-persistence

Persist form data to the database and makes them downloadable
MIT License
7 stars 7 forks source link

Type error when using the finisher #37

Closed kdambekalns closed 2 years ago

kdambekalns commented 2 years ago

In https://github.com/punktDe/form-persistence/blob/2b0d093b2ba5389763c8d77acb59e3b9cc4e4136/Classes/Finishers/SaveFormDataFinisher.php#L80 the fallback is an empty string.

But the method expects an array as argument: https://github.com/punktDe/form-persistence/blob/2b0d093b2ba5389763c8d77acb59e3b9cc4e4136/Classes/Domain/Model/FormData.php#L187

This leads to Argument 1 passed to PunktDe\Form\Persistence\Domain\Model\FormData_Original::setContentDimensions() must be of the type array, string given, called in /…/PunktDe_Form_Persistence_Finishers_SaveFormDataFinisher.php on line 80