punktDe / form-persistence

Persist form data to the database and makes them downloadable
MIT License
7 stars 7 forks source link

Missing dependency on phpoffice/phpspreadsheet in 2.6.3 #51

Open kdambekalns opened 2 years ago

kdambekalns commented 2 years ago

This is what packagist knows about 2.6.2:

image

And this is what packagist knows about 2.6.3:

image

The reason is tagging on the wrong branch…

kdambekalns commented 2 years ago

This has happened (in similar form) with 2.5.2, which was released from 2.0 and later superseded by 2.5.3 from the 2.5 branch.

2.6.0, 2.6.1 and 2.6.2 were released from master, but 2.6.3 from 2.0.

Reason was (as it seems) the merge of #38 into 2.0 and not realising that 2.0 was no longer active. So 2.0 should then have been merged into 2.5. Then a release of 2.5.4 from 2.5 would have been good. Another upmerge into master, release 2.6.3 from there.

Bottom line: what is 3.0.0 should be 2.6.3 🤷‍♂️

To fix this…

Optionally delete the 2.0, 2.5 (and 2.6) branches to avoid such confusion in the future. If needed a 2.x branch can be created "for future use"… 😎