While this package is very useful, I think that the site name is not the best choice as key for defining a configuration. The site name is user-editable in the Neos backend, while Settings are in the code. Furthermore, the site name can contain spaces and umlauts which could theoretically be problematic. I assume it isn't easy to change to the rootNode name (which I think would be a better choice), but I wanted to put it to discussion.
While this package is very useful, I think that the site name is not the best choice as key for defining a configuration. The site name is user-editable in the Neos backend, while Settings are in the code. Furthermore, the site name can contain spaces and umlauts which could theoretically be problematic. I assume it isn't easy to change to the rootNode name (which I think would be a better choice), but I wanted to put it to discussion.