search

punxaphil / maxi-media-player

Media card for Home Assistant UI with a focus on managing multiple media players, but not excluding single player setups.
7 stars 1 forks source link

feature: add editor settings to allow show / hide of player control buttons repeat, shuffle, next track, previous track, and power. Also adds power button to player-controls if current player state is off so the player can be turned back on. #15

Closed thlucas1 closed 2 months ago

thlucas1 commented 2 months ago

Does this look ok?

punxaphil commented 2 months ago

Thanks I'll take look later. Resolving a conversation us usually done by the person who left the original comment. So please unresolve the conversations above until I have read your answers.

thlucas1 commented 2 months ago

It looks like another change to main occurred while I was making my changes. I thought I merged everything successfully into my featurePlayerControlsHidShow branch, but not sure as the volume slider control on the player section no longer works in my testing. It appears changes were made to the volume controls with this latest update, so not sure if that is the problem or if I missed merging something.

I think at this point I am giving up on being a contributor to this project. I don't think my GIT skills are up to the challenge of a multi-user development environment like this. I am used to making changes on the master / main branch, moving them in, and moving on to the next change. With this project, I am spending more time trying to figure out what to do with GIT and how to accommodate other changes than I am trying to make the card better or fix bugs.

I will continue to use the discussion forum to provide feature requests and ideas. Again, the maxi-media-player does not have a discussions forum built, so if you could add that to the repository settings that would be great.

Take care, and best of luck with the card.

punxaphil commented 2 months ago

It looks like another change to main occurred while I was making my changes. I thought I merged everything successfully into my featurePlayerControlsHidShow branch, but not sure as the volume slider control on the player section no longer works in my testing. It appears changes were made to the volume controls with this latest update, so not sure if that is the problem or if I missed merging something.

I think at this point I am giving up on being a contributor to this project. I don't think my GIT skills are up to the challenge of a multi-user development environment like this. I am used to making changes on the master / main branch, moving them in, and moving on to the next change. With this project, I am spending more time trying to figure out what to do with GIT and how to accommodate other changes than I am trying to make the card better or fix bugs.

Sorry to hear that. Yeah, I guess git is a required skill to collaborate on open source projects. I think you are doing a fine job so far, but it's up to you.

I will continue to use the discussion forum to provide feature requests and ideas. Again, the maxi-media-player does not have a discussions forum built, so if you could add that to the repository settings that would be great.

For feature requests and bugs, just use the issues section.

punxaphil commented 2 months ago

I'll merge this to a feature branch in base repo to try it out further

thlucas1 commented 2 months ago

Thank you.

punxaphil commented 2 months ago

Can you please review and test this one? https://github.com/punxaphil/maxi-media-player/pull/22