feature: make it possible to hide player control buttons

thlucas1 commented 5 months ago

I can't figure out how to get the changes from your e6513e9 commit into my forked repository to test them.

punxaphil commented 5 months ago

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork#syncing-a-fork-branch-with-the-github-cli

Something like this:

gh repo sync thlucas1/featurePlayerControlsHideShow -b featurePlayerControlsHideShow --force

punxaphil commented 5 months ago

You might be able to do it in the GUI as well, not sure: https://github.com/thlucas1/maxi-media-player/tree/featurePlayerControlsHideShow

thlucas1 commented 5 months ago

Ok ... I was able to sync the changes up and test them in my Bose SoundTouch environment. I did the following:

Single Player Mode

verified that player section control buttons could be hidden / shown (power, next track, previous track, repeat, shuffle) as configured.
verified that volume section power button was hidden / shown as configured.
verified that after powering off, the power button was shown on the player section if media player supports turn_on service and power button is configured to be shown.

Group Player Mode

verified that player section control buttons could be hidden / shown (power, next track, previous track, repeat, shuffle) as configured.
verified that volume section power button was hidden / shown as configured for all media players.
verified that after powering off, the power button was shown on the player section if media player supports turn_on service and power button is configured to be shown.

Other Thoughts Not related to your changes, but while you are in there ... The volumes section volume step up / down and volume cogwheel icons are not styled likes the mute and power icons, which makes them look odd or out of place. Example:

Other than that, it all looks great! Thanks.

punxaphil commented 5 months ago

That looks odd. Do you have custom styling?

thlucas1 commented 5 months ago

DOH! My apologies - I did have custom styling via card-mod. Here's what it looks like without the card-mod:

All good! Thanks.

thlucas1 commented 5 months ago

I did notice something else though after powering off the devices.

It seems that the volume slider displays 100% when the device is powered off. It does this on both the Volumes section and Grouping section. The Volumes section also displays a "0%NaN%" value. It makes me think that when I power the speaker back on that the volume will be 100%, but it does not - it powers back on at the previous volume. Is there a way to just leave the volume display at the last known volume level when powered off? Or maybe set it to zero (instead of 100) if powered off?

punxaphil commented 5 months ago

I thought I was hiding that when off. Can you see if you can fix it?

thlucas1 commented 5 months ago

Submitted PR #23

punxaphil commented 5 months ago

https://github.com/punxaphil/maxi-media-player/releases/tag/v1.6.0

punxaphil / maxi-media-player

feature: make it possible to hide player control buttons #22