search

pupgray / walltaker

Take control of your friends wallpapers
6 stars 5 forks source link

Display previous wallpapers on link page #21

Closed kemagain closed 8 months ago

kemagain commented 9 months ago

~INCOMPLETE; Opening a draft PR to make it easier for gray to review code as he goes.~

Ready to review.

This is a pretty basic implementation. A brief wallpaper history on the link page, as well as a link to a dedicated history page that shows up to 50.

There's a lot of polish I intend to add as follow up PRs, but for now I figure it's easiest to get this code in as it's functional on its own and everything else is gonna be based on it.

kemagain commented 9 months ago

~Know what? There are some off-by-one errors in the logic for showing/hiding the history based on presence/absence of wallpapers, aren't there? Let me take a look and fix them~

Just kidding, I forgot that the code in question was correct lmao

kemagain commented 9 months ago

I went ahead and cherrypicked the cosmetic improvements + username of each person who set the given wallpaper. No reason to leave those exclusive to the later changes when it significantly improves the utility of this page.

kemagain commented 8 months ago

Closing: The full retroactive reactions + history item is done, so this is redundant.