Retroactive reactions & Link History - Githubissues

pupgray / walltaker

Take control of your friends wallpapers

5 stars 5 forks source link

Retroactive reactions & Link History #22

Closed kemagain closed 4 months ago

kemagain commented 7 months ago

Rough scope:

Small number of previous wallpapers show up on the link page
History page for each link that shows last 50 wallpapers
Reactions can be sent for past wallpapers on the history page
Reactions can be viewed for past wallpapers
Notification sent to the person that set the wallpaper
Reaction shows up in the link chat
Moderate refactors to make the above possible/practical

kemagain commented 7 months ago

force-push to bring this branch back in line with its companion PR; I'm cutting the scope of this PR drastically in order to split up any major refactors into a followup PR.

kemagain commented 7 months ago

update: I decided to change course and include persisting previous reactions in with the rest of this work. it ended up making way more sense as it's honestly easier to ensure that the correct reaction is being displayed (given that retroactive "hated it" reactions tamper with the history a bit)

kemagain commented 6 months ago

force-pushed to unfuck a bad merge

kemagain commented 6 months ago

still todo:

history actions really REALLY need to be in their own controller
- Unfuck routing mess and use actual path helpers after doing this
make the page not look like dogshit
- probably more work than it sounds like lmao

kemagain commented 6 months ago

Ready for full review. The commit history is a bit of a slog due to the fact that I was still trying to untangle some Rails basics and separate "writing the thing" from "figuring out where the code goes".

kemagain commented 6 months ago

I'm pulling this back into a draft as it's not safe to merge right now; turns out that I had an oversight when reworking the modal, and now the page will 404 when you react with "Hate it" on a past post. Gotta fix the page to kick the user back to the link history/refresh the page.

dogkisser commented 6 months ago

this will be the merge to end all merges

kemagain commented 6 months ago

this will be the merge to end all merges

i merged your mom last night

dogkisser commented 6 months ago

i merged your mom last night

i didn't sign off on that

kemagain commented 5 months ago

I came back and added some late comments to cover things I think I only ever mentioned in passing over discord DMs. Much more appropriate for them to be here.

pupgray commented 5 months ago

Back from vacation, and eye healed up, looking at this finally!

kemagain commented 5 months ago

happy to hear it!

i hope you find the code useful enough to work with

unfortunately i may not be able to follow up with any more work or commentary past this point. im slowing down around this corner of the internet as im pretty burned out and need a break from it

kemagain commented 4 months ago

closing: gray has a copy of the code, and i'm cleaning out this fork from my own repository list