pupil-labs / apriltags

Python bindings for the apriltags3 library
https://pupil-apriltags.readthedocs.io/en/latest/index.html
Other
106 stars 29 forks source link

Allow apriltags to be installed with VS 2019 #44

Closed philipxyc closed 2 years ago

philipxyc commented 3 years ago

This argument actually fixed the version of visual studio to VS 2017, the best way is to remove this tag. But read from the comment above, it seems like some CI issue will happen if remove this argument. For now, it makes more sense if the default VS needed is 2019, and it's needed to be written in the readme to say "only VS 2019/2017 build tool can be used to install this package".

papr commented 2 years ago

Fixed in #50