search

pupil-labs / pupil-detectors

GNU Lesser General Public License v3.0
24 stars 18 forks source link

Allow running 3D detector from binary data of 2D detector #9

Closed pfaion closed 4 years ago

pfaion commented 4 years ago

This PR allows running the 3D detector without always running the internal 2D detector.

The 2D detector now publishes a binary representation of the Detector2DResult struct, which can be fed into the 3D detector, making it re-use the existing Detector2DResult and skipping the additional internal 2D detector.

An integration for Pupil is available in https://github.com/pupil-labs/pupil/pull/1850 This branch however also runs fine with the previous versions of Pupil.

pfaion commented 4 years ago

@papr I'd bump the version on master after merging, so we can just run bump2version (which also creates a tag, that I'd rather have on master)