pupil-labs / pupil-invisible-monitor

DEPRECATED - Use https://docs.pupil-labs.com/invisible/how-tos/data-collection-with-the-companion-app/monitor-your-data-collection-in-real-time.html instead.
GNU Lesser General Public License v3.0
10 stars 3 forks source link

Clean up and fix requirements installation workflow #22

Closed pfaion closed 4 years ago

pfaion commented 4 years ago

This PR intends to clean up the dependency setup with the multiple requirements.txt files and fixes missing dependencies for Windows. This is a result of the discussion in #21

Relevant Changes

Additional Notes

Since PEP508 all the required options can be handled via install_requires:

@papr @romanroibu can one of you test if this works on macOS? As in:

  1. Make sure you don't have glfw installed in brew.
  2. Create a clean virtualenv.
  3. Just pip install . or pip install -e . from this repo.
  4. Run pupil_invisible_monitor, make sure the app starts and you get an image from a PI.
pfaion commented 4 years ago

This is working on Windows with the glfw3.dll removed and on Linux with libglfw3 uninstalled from apt.

papr commented 4 years ago

Unfortunately, I do not have a 1+6 at home, but the installation went smoothly and the app starts correctly on macOS without brewed glfw.