search

pupil-labs / pupil

Open source eye tracking
https://pupil-labs.com
GNU Lesser General Public License v3.0
1.49k stars 680 forks source link

Player - offline calibration - new sections should have a default calibration range that spans the full video. #996

Closed gabrielDiaz-performlab closed 6 years ago

mkassner commented 6 years ago

We choose to do a smaller section to show the user that this is adjustable.

gabrielDiaz-performlab commented 6 years ago

Isn't this made explicit by the "calibration range" field?

If you choose the default to a smaller section, then I suggest that you add a button for "select entire range."

Gabriel J. Diaz, Ph.D. Assistant Professor Rochester Institute of Technology Chester F. Carlson Center for Imaging Science

Founder of PerForM Labs Click for demos. https://www.cis.rit.edu/performlab/

Office 2108, Building #76 Rochester, NY 14623 Office: (585) 475-6215 gabriel.diaz@rit.edu

On Thu, Jan 4, 2018 at 3:40 AM, Moritz Kassner notifications@github.com wrote:

We choose to do a smaller section to show the user that this is adjustable.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pupil-labs/pupil/issues/996#issuecomment-355226953, or mute the thread https://github.com/notifications/unsubscribe-auth/AIi_23sPiK4BxijC_d0QHRH9JkEpObdUks5tHI6IgaJpZM4RSRIc .

papr commented 6 years ago

Isn't it the actual problem that setting the ranges (both calibration and mapping) is way too painful when using the text field?

I suggest we look for an intuitive way to change the ranges without adding further ui that is only useful for special cases anyway...

cpicanco commented 6 years ago

Writing numbers using the number pad is sort of tricky in text fields. There is sanitization, but instead of a simple warning when strange characters or formats are found, the field will be reseted. You need to care about brackets and commas. The enter key in the number pad does not work in text fields. Right now it is a nighmare.

cpicanco commented 6 years ago

But removing them completely would be worse. So I think some redundancy would be nice.

papr commented 6 years ago

No, you are right. The text field needs to stay for precise input. But we need a method to change the ranges quickly without having to be precise.

papr commented 6 years ago

Will be fixed with #1057