search

pupil-labs / pupil

Open source eye tracking
https://pupil-labs.com
GNU Lesser General Public License v3.0
1.49k stars 680 forks source link

Player (Mac - 1.2.7) - A click on video timeline is unresponsive. #997

Closed gabrielDiaz-performlab closed 6 years ago

gabrielDiaz-performlab commented 6 years ago

I cannot jump to a point in the video anymore. Sad.

mkassner commented 6 years ago

@performlabrit you mean you would like to click instead of drag? I think that could be usefull. @papr what do you think?

gabrielDiaz-performlab commented 6 years ago

No, I mean that the timeline is entirely unresponsive to any mouse interactions at all.

Gabriel J. Diaz, Ph.D. Assistant Professor Rochester Institute of Technology Chester F. Carlson Center for Imaging Science

Founder of PerForM Labs Click for demos. https://www.cis.rit.edu/performlab/

Office 2108, Building #76 Rochester, NY 14623 Office: (585) 475-6215 gabriel.diaz@rit.edu

On Thu, Jan 4, 2018 at 3:40 AM, Moritz Kassner notifications@github.com wrote:

@performlabrit https://github.com/performlabrit you mean you would like to click instead of drag? I think that could be usefull. @papr https://github.com/papr what do you think?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pupil-labs/pupil/issues/997#issuecomment-355226858, or mute the thread https://github.com/notifications/unsubscribe-auth/AIi_250j8LIYd1GYzBr6Na8NyMLDu2Jfks5tHI5ngaJpZM4RSTJM .

papr commented 6 years ago

Please be aware that moving the time indicator is only possible in the lower part. I know that it is confusing that it extends upwards but is not draggable in that area.

If you confirm that this is the issue, I will rename the issue to change that behavior and fix it in the coming week.

gabrielDiaz-performlab commented 6 years ago

Yeah, there is no region with which I can interact.

I wonder if this is related to the same issue that has ​previously ​ caused the pixel position of a new natural feature to be displaced from the position under the mouse.

Gabriel J. Diaz, Ph.D. Assistant Professor Rochester Institute of Technology Chester F. Carlson Center for Imaging Science

Founder of PerForM Labs Click for demos. https://www.cis.rit.edu/performlab/

Office 2108, Building #76 Rochester, NY 14623 Office: (585) 475-6215 gabriel.diaz@rit.edu

On Thu, Jan 4, 2018 at 7:18 AM, Pablo Prietz notifications@github.com wrote:

Please be aware that moving the time indicator is only possible in the lower part. I know that it is confusing that it extends upwards but is not draggable in that area.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pupil-labs/pupil/issues/997#issuecomment-355268540, or mute the thread https://github.com/notifications/unsubscribe-auth/AIi_2zV9s4tZUST96_ACohnNeRw-C9BIks5tHMGTgaJpZM4RSTJM .

papr commented 6 years ago

Are you able to change the trim mark positions?

gabrielDiaz-performlab commented 6 years ago

Yes, I am. Also, a bit more playing shows that there is a very thin horizontal region between the visual location of the timeline that does react to mouse interaction. It's fine, and takes a lot of clicking around to find.

Gabriel J. Diaz, Ph.D. Assistant Professor Rochester Institute of Technology Chester F. Carlson Center for Imaging Science

Founder of PerForM Labs Click for demos. https://www.cis.rit.edu/performlab/

Office 2108, Building #76 Rochester, NY 14623 Office: (585) 475-6215 gabriel.diaz@rit.edu

On Thu, Jan 4, 2018 at 7:21 AM, Pablo Prietz notifications@github.com wrote:

Are you able to change the trim mark positions?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pupil-labs/pupil/issues/997#issuecomment-355269065, or mute the thread https://github.com/notifications/unsubscribe-auth/AIi_266FLsnVN05hS6vByTid4lPLuvZ6ks5tHMJPgaJpZM4RSTJM .

papr commented 6 years ago

You mentioned that you are using a Mac with Retina Display. Could you specify which Mac exactly?

gabrielDiaz-performlab commented 6 years ago

​Macbook Pro with 15 inch retina display 2016 ​

Gabriel J. Diaz, Ph.D. Assistant Professor Rochester Institute of Technology Chester F. Carlson Center for Imaging Science

Founder of PerForM Labs Click for demos. https://www.cis.rit.edu/performlab/

Office 2108, Building #76 Rochester, NY 14623 Office: (585) 475-6215 gabriel.diaz@rit.edu

On Thu, Jan 4, 2018 at 7:27 AM, Pablo Prietz notifications@github.com wrote:

You mentioned that you are using a Mac with Retina Display. Could you specify which Mac exactly?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pupil-labs/pupil/issues/997#issuecomment-355270275, or mute the thread https://github.com/notifications/unsubscribe-auth/AIi_2-N7x9m80ecAminoaQ9qp_J5o88hks5tHMPFgaJpZM4RSTJM .

papr commented 6 years ago

Ok, I will try to improve the ui handling starting next week.

gabrielDiaz-performlab commented 6 years ago

Ok. So, now I'm clicking around some more and finding that I can interact. I'm not sure what changed, though - the inability to interact has been persistent across multiple sessions, so it's not a rare irreproducible bug. I'll try and track down the cause/remedy and will let you know what I find.

Gabriel J. Diaz, Ph.D. Assistant Professor Rochester Institute of Technology Chester F. Carlson Center for Imaging Science

Founder of PerForM Labs Click for demos. https://www.cis.rit.edu/performlab/

Office 2108, Building #76 Rochester, NY 14623 Office: (585) 475-6215 gabriel.diaz@rit.edu

On Thu, Jan 4, 2018 at 7:34 AM, Pablo Prietz notifications@github.com wrote:

Ok, I will try to improve the ui handling starting next week.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pupil-labs/pupil/issues/997#issuecomment-355271389, or mute the thread https://github.com/notifications/unsubscribe-auth/AIi_2yM3SQUdYpo5B_JMZuRmLNycGEUHks5tHMU5gaJpZM4RSTJM .

papr commented 6 years ago

Currently, this should be the area where the indicator is draggable:

screenshot 2018-01-04 13 40 08
cpicanco commented 6 years ago

Sometimes the problem is that the app itself is unresponsive. The player (since the introduction of autoupdate everywhere through events) is hanging a lot.

gabrielDiaz-performlab commented 6 years ago

Yes, I'm clear on that. That draggable area is unresponsive. Here is a video demonstrating the issue. Sadly, you can't tell when I'm clicking from the video, but be assured that Im clicking like mad.

https://www.dropbox.com/s/twpv9k23f2qchbm/pupil_player_scrollBarBug.mov?dl=0

Gabriel J. Diaz, Ph.D. Assistant Professor Rochester Institute of Technology Chester F. Carlson Center for Imaging Science

Founder of PerForM Labs Click for demos. https://www.cis.rit.edu/performlab/

Office 2108, Building #76 Rochester, NY 14623 Office: (585) 475-6215 gabriel.diaz@rit.edu

On Thu, Jan 4, 2018 at 7:45 AM, Pablo Prietz notifications@github.com wrote:

Currently, this should be the area where the indicator is draggable: [image: screenshot 2018-01-04 13 40 08] https://user-images.githubusercontent.com/168390/34564011-69904d06-f155-11e7-9d43-ed22f09d5499.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pupil-labs/pupil/issues/997#issuecomment-355273495, or mute the thread https://github.com/notifications/unsubscribe-auth/AIi_2x0HaGE1nRNC_5aAAF_k-ilQxAugks5tHMfegaJpZM4RSTJM .

gabrielDiaz-performlab commented 6 years ago

Certain aspects of the app are responsive. I can mess with trim regions and region boundaries without noticeable delay.

Gabriel J. Diaz, Ph.D. Assistant Professor Rochester Institute of Technology Chester F. Carlson Center for Imaging Science

Founder of PerForM Labs Click for demos. https://www.cis.rit.edu/performlab/

Office 2108, Building #76 Rochester, NY 14623 Office: (585) 475-6215 gabriel.diaz@rit.edu

On Thu, Jan 4, 2018 at 7:56 AM, Rafael Picanço notifications@github.com wrote:

Sometimes the problem is that the app itself is unresponsive. The player (since the introduction of autoupdate everywhere through events) is hanging a lot.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pupil-labs/pupil/issues/997#issuecomment-355275626, or mute the thread https://github.com/notifications/unsubscribe-auth/AIi_2ysEsbMEcZeBgtXxoFqqS4aA2G7Tks5tHMqLgaJpZM4RSTJM .

cpicanco commented 6 years ago

@performlabrit , you need to click on top of the left most line inside the draggable area.

papr commented 6 years ago

Try dragging here:

screenshot 2018-01-04 13 59 51

Please be aware that clicking somewhere to jump there is currently not implemented!

cpicanco commented 6 years ago

Also, you can press space key to start-stop playing.

gabrielDiaz-performlab commented 6 years ago

Yes, I can press the space key. Pablo, I'll pay attention to your previous suggestion and see if it's simply a matter of me expecting behavior that isn't yet implemented. If that's the case, then I suggest some sort of visual aid (e.g. a circle in the clickable region that visually responds to a click).

Gabriel J. Diaz, Ph.D. Assistant Professor Rochester Institute of Technology Chester F. Carlson Center for Imaging Science

Founder of PerForM Labs Click for demos. https://www.cis.rit.edu/performlab/

Office 2108, Building #76 Rochester, NY 14623 Office: (585) 475-6215 gabriel.diaz@rit.edu

On Thu, Jan 4, 2018 at 8:05 AM, Rafael Picanço notifications@github.com wrote:

Also, you can press space key to start-stop playing.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pupil-labs/pupil/issues/997#issuecomment-355277217, or mute the thread https://github.com/notifications/unsubscribe-auth/AIi_29aaU3cUzLJlRl_00nQjZOfU9FOYks5tHMyAgaJpZM4RSTJM .

papr commented 6 years ago

You are right, but I think it is better to implement the expected behavior than adding aids for the restricted behavior. :)

gabrielDiaz-performlab commented 6 years ago

Agreed. Thanks!

Gabriel J. Diaz, Ph.D. Assistant Professor Rochester Institute of Technology Chester F. Carlson Center for Imaging Science

Founder of PerForM Labs Click for demos. https://www.cis.rit.edu/performlab/

Office 2108, Building #76 Rochester, NY 14623 Office: (585) 475-6215 gabriel.diaz@rit.edu

On Thu, Jan 4, 2018 at 8:16 AM, Pablo Prietz notifications@github.com wrote:

You are right, but I think it is better to implement the expected behavior than adding aids for the restricted behavior. :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pupil-labs/pupil/issues/997#issuecomment-355279395, or mute the thread https://github.com/notifications/unsubscribe-auth/AIi_25jHkC_usVrEGX5AnwI88Wa0Yymgks5tHM8ggaJpZM4RSTJM .