Reduce area of the square to minimize FitBox onclick

[cpicanco]

Hi, I have a suggestion.

The problem

Because the entire title bar area is being used, the minimize onClick is conflicting with the BringToFront onClick functionality.

Solution 1

Instead of using the entire title bar area, the minimize area onClick could be reduced to the ICON square ().

Solution 2

Minimize onDoubleClick in the entire title bar. (However, this conflicts with existing standards, double click on the title bar usually means "expand the window to client boundaries" or "reduce the window to the last reduced state".)

[papr]

Solution 3

Successful executed BringToFront action consumes the input. Therefore it would only minimize if the menu is already in front.

@cpicanco What do you think?

[cpicanco]

Good!

[mkassner]

Consumption of input would be strange if the window is already fully visible.

I would try solution 1 and see how that feels.

M

On Wed, Aug 31, 2016 at 6:22 PM, Rafael Picanço notifications@github.com wrote:

Good!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pupil-labs/pyglui/issues/35#issuecomment-243818929, or mute the thread https://github.com/notifications/unsubscribe-auth/ABXgp5YjPCuHVZ-O-5vX3XzaQb3Ssskgks5qlao0gaJpZM4Jxv6b .

[cpicanco]

@mkassner , @papr 's suggestion implies that the consumption of the input must not occur if the window is fully visible.

[mkassner]

Yes, while thats possible. Its technically cumbersome and I dont think that it would feel consistent/logical for the user.

On Wed, Aug 31, 2016 at 7:32 PM, Rafael Picanço notifications@github.com wrote:

@Moritz https://github.com/Moritz, @papr https://github.com/papr 's suggestion implies that the consumption of the input must not occur if the window is fully visible.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pupil-labs/pyglui/issues/35#issuecomment-243839679, or mute the thread https://github.com/notifications/unsubscribe-auth/ABXgp6r8wSGRlBLhz6pddYTFLIV0qamEks5qlbqvgaJpZM4Jxv6b .

[cpicanco]

Well, suggestion 1 then!

[papr]

@cpicanco Could you test the PR?

[cpicanco]

@papr , yep

[cpicanco]

Functionality is working. However, I think I have found a bug. I checked and it was not introduced by any commit since fd3faf098b8ae0d3a991415600d714e52668fc48.

I will create a separated issue for that.

[cpicanco]

37