make text input look good

pupil-labs / pyglui

cython powered OpenGL gui that works with glfw

MIT License

29 stars 20 forks source link

make text input look good #6

Closed mkassner closed 9 years ago

mkassner commented 9 years ago

add caret.
use textbox (this should be implemented in pyfontstash)
deal with overflow though sideways scrolling text

mkassner commented 9 years ago

mostly done. Overflow will not show. Caret is rendered.

willpatera commented 9 years ago

Fixed caret behavior for delete event. Prior to latest commit, when caret was moved to the 0 index (all the way left) with text remaining and delete key pressed, the would result in unwanted addition to self.preview list. See changes at this commit -- https://github.com/pupil-labs/pyglui/commit/10951189d6bea02e790989e1277bca807b519d1b.

I also disabled color change for text on selection. glfont.set_color_float changes the state for the fontstash context and therefore changes all subsequent font colors to the selection color specified unless you reset the state.

willpatera commented 9 years ago

Added a highlight line below the text when selected.

willpatera commented 9 years ago

Feature request (todo)

select multiple characters of text
- ~~double click~~ long press (better for touch) to select & highlight all text input in the text field
- drag from mouse pos to select a portion of the text & highlight - this could also be shift + left/right arrow keys to highlight text.

willpatera commented 9 years ago

Added functionality

text select keyboard - highlight with the caret using shift + right-arrow or shift+left-arrow
highlighted selection is rendered with rectangle
highlighted selection can be deleted

mkassner commented 9 years ago

Bugreport: Selecting with shift and arrow key works but when releasing shift key selection process with left arrow continues while using right arrow will stop it.

Over writing selected text is funny, I guess having the first key input replace the selection would be best.

mkassner commented 9 years ago

Feature Request: Deal with overflowing text:

upon entering select more the text should scroll to the end.
navigating text with caret should scroll the text so the caret is never invisible.

willpatera commented 9 years ago

I'm moving some of these bugs and features into their own issue. I created a branch for text input so that we don't have too many merge conflicts in master.

willpatera commented 9 years ago

Feature - Make caret blink

willpatera commented 9 years ago

Closing - almost all features implemented (aside from blinking caret -- that one can be done later :)