search

pupnp / pupnp

libupnp: Build UPnP-compliant control points, devices, and bridges on several operating systems.
https://pupnp.github.io/pupnp
BSD 3-Clause "New" or "Revised" License
353 stars 117 forks source link

Logging Improvements, Tidying #285

Closed whyman closed 3 years ago

whyman commented 3 years ago

Wow, the CI runs really old compilers! GNU 5.5.0 :sauropod:

I guess I will have to check for compiler support.

FWIW, its available in >=GCC 8, and >=clang 11

Nice improvement in terms of reproducibility too.

whyman commented 3 years ago

Example of the log format:

2021-03-30 13:44:09 DEBG UPNP:API  [0x000000000000B757][upnp/src/api/upnpapi.cpp:260] Inside UpnpInitPreamble
2021-03-30 13:44:09 DEBG UPNP:API  [0x000000000000B757][upnp/src/api/upnpapi.cpp:277] Trying a write lock
2021-03-30 13:44:09 DEBG UPNP:API  [0x000000000000B757][upnp/src/api/upnpapi.cpp:277] Write lock acquired
2021-03-30 13:44:09 DEBG UPNP:API  [0x000000000000B757][upnp/src/api/upnpapi.cpp:279] Trying Unlock
2021-03-30 13:44:09 DEBG UPNP:API  [0x000000000000B757][upnp/src/api/upnpapi.cpp:279] Unlocked rwlock
2021-03-30 13:44:09 INFO UPNP:API  [0x000000000000B757][upnp/src/api/upnpapi.cpp:417] UpnpInit2 with IfName=NULL, DestPort=0.
2021-03-30 13:44:09 INFO UPNP:API  [0x000000000000B757][upnp/src/api/upnpapi.cpp:4075] Interface name=enx98e743aa385f, index=3, v4=172.16.0.99, v6=fe80::e5ff:5d74:8c3d:1194, ULA or GUA v6=
2021-03-30 13:44:09 INFO UPNP:API  [0x000000000000B757][upnp/src/api/upnpapi.cpp:333] Entering UpnpInitStartServers
2021-03-30 13:44:09 INFO UPNP:MSER [0x000000000000B757][upnp/src/genlib/miniserver/miniserver.c:956] get_miniserver_sockets: resuseaddr is set.
2021-03-30 13:44:09 INFO UPNP:MSER [0x000000000000B757][upnp/src/genlib/miniserver/miniserver.c:618] sockfd = 4, .... port = 49152
2021-03-30 13:44:09 INFO UPNP:MSER [0x000000000000B757][upnp/src/genlib/miniserver/miniserver.c:618] sockfd = 5, .... port = 49152
2021-03-30 13:44:09 INFO UPNP:MSER [0x000000000000B757][upnp/src/genlib/miniserver/miniserver.c:618] sockfd = 6, .... port = 49153
2021-03-30 13:44:09 INFO UPNP:MSER [0x000000000000B757][upnp/src/genlib/miniserver/miniserver.c:981] get_miniserver_sockets: bind successful
2021-03-30 13:44:09 INFO UPNP:MSER [0x000000000000B757][upnp/src/genlib/miniserver/miniserver.c:618] sockfd = 7, .... port = 59501
2021-03-30 13:44:09 DEBG UPNP:API  [0x000000000000B757][upnp/src/api/upnpapi.cpp:366] Exiting UpnpInitStartServers

Not sure why ThreadID is quite so wide?

mrjimenez commented 3 years ago

Its a 64 bit pointer. Very ugly indeed. :disappointed: Should we truncate it?