CMake: Add LFS definitions when needed

pupnp / pupnp

libupnp: Build UPnP-compliant control points, devices, and bridges on several operating systems.

https://pupnp.github.io/pupnp

BSD 3-Clause "New" or "Revised" License

352 stars 115 forks source link

CMake: Add LFS definitions when needed #348

Closed whyman closed 2 years ago

whyman commented 2 years ago

Previously we worked out if we needed them, but then they werent set

whyman commented 2 years ago

No idea whats happening in the CI, unrelated it seems

Vollstrecker commented 2 years ago

Rough guess, they changed master to something more political correct. Btw. I'm no friend of add_compile_definitions, I would suggest setting the corresponding var for LFS and add a conditional gen-exp where needed. Just to be sure the flag doesn't propagte to other targets when we are built as a subbuilt. I can't give a clearer explanation atm. but I hope I get the time to adress the various stuff after the 20th if my words are to weird to follow (wouldn't be surprised).

Vollstrecker commented 2 years ago

The CI problem was solved last week. I created a pr that makes the flags part of ixml interface, so everything should propagate up to the last binary.