1.16: Should we remove Printf from the API

pupnp / pupnp

libupnp: Build UPnP-compliant control points, devices, and bridges on several operating systems.

https://pupnp.github.io/pupnp

BSD 3-Clause "New" or "Revised" License

352 stars 117 forks source link

1.16: Should we remove Printf from the API #365

Open whyman opened 2 years ago

whyman commented 2 years ago

It seems like UpnpLog::UpnpPrintf is only meant for internal library usage.

The UpnpLog class should still be there for configuring the library logging stuff, but we shouldn't expose the actual logging method itself.

Thoughts?

Vollstrecker commented 2 years ago

Absolutely right. But as I still didn't get the time to find out what options are needed to only expose the functions that should be, it wouldn't make a big difference, as atm everything is reachable from outside.

mrjimenez commented 2 years ago

It could be removed, it is really a convenience to make it easier to do tests. But I think that right now, not even the tests use it explicitly, only indirectly.