search

pupnp / pupnp

libupnp: Build UPnP-compliant control points, devices, and bridges on several operating systems.
https://pupnp.github.io/pupnp
BSD 3-Clause "New" or "Revised" License
352 stars 115 forks source link

UpnpExtraHeaders.h missing from cmake build in branch-1.14x #384

Closed kyak closed 2 years ago

kyak commented 2 years ago

UpnpExtraHeaders.h is missing when doing cmake build in branch-1.14x. This leads to errors when building downstream software, like gerbera: https://github.com/gerbera/gerbera/issues/2506

Vollstrecker commented 2 years ago

Compare: https://github.com/pupnp/pupnp/commit/124046339933c7310918e9d4c28051cef9079a9f

kyak commented 2 years ago

Compare: 1240463

I frankly have no idea what you mean by this.

neheb commented 2 years ago

He's pointing out why this bug was introduced.

Vollstrecker commented 2 years ago

Yep, but it seems this never made it into 1.14.x, so my bad.

whyman commented 2 years ago

It can't be renamed in stable right?

Vollstrecker commented 2 years ago

It could, but this would mean a versioncheck and conditional for your include. Given between 1.14.x and 1.16.x this would be also needed but this is a new release, on bugfixbranches I would avoid such changes. From my personal feelings such thing belong into major releases, but 1.14 to 1.16 (why not 1.15?) feels like a major one in this project, especially as major means breaking features and by now no features for a new release at all are on their way.