search

pupnp / pupnp

libupnp: Build UPnP-compliant control points, devices, and bridges on several operating systems.
https://pupnp.github.io/pupnp
BSD 3-Clause "New" or "Revised" License
349 stars 114 forks source link

Fixes broken cmake regex #443

Closed mrjimenez closed 3 weeks ago

mrjimenez commented 3 weeks ago

That is the output

-- Found Git: /usr/bin/git (found version "2.44.0") 
-- Extracted package name is libupnp
-- Setting package-version to 1.14.20
-- Left from parsing: ,mroberto@users.sourceforge.net
-- Setting ixml-soversion to 11.1.2
-- Setting upnp-soversion to 17.1.11
-- package-version is 1.14.20
-- The C compiler identification is GNU 13.2.1
-- The CXX compiler identification is GNU 13.2.1
...
loqs commented 3 weeks ago

Being pedantic [0-9]* matches zero or more times. Is it valid for any part of the triplet to be empty? Or should it be [0-9]+ to match one or more times?

mrjimenez commented 3 weeks ago

Hi @dvzrv do you think you can test it? If this is ok for you I will do another release to include this.

mrjimenez commented 3 weeks ago

Being pedantic [0-9]* matches zero or more times. Is it valid for any part of the triplet to be empty? Or should it be [0-9]+ to match one or more times?

Totally correct, lets fix it.