search

puppetlabs-toy-chest / lumogon

Get a complete picture of what your applications are made of *without* changing how you currently build and run containers. Just run and report.
Other
198 stars 14 forks source link

(MAINT) Repair Analytics Reporting Regression #37

Closed jfryman closed 7 years ago

jfryman commented 7 years ago

This PR fixes an issue introduced in https://github.com/puppetlabs/lumogon/commit/d128444ce0da6c5540a2cf78b6a14b15bd35439b where the correct Viper bind is not used for the disable-analytics endpoint. As a result, this has been ignored and all reports have been sending analytics data upstream regardless of flag being set.

jfryman commented 7 years ago

Correct codepath being followed here. 

[lumogon] 2017/05/24 18:28:57.082966 [Analytics] Gathering analytics for screen-view, report
[lumogon] 2017/05/24 18:28:57.082993 [Docker Adapter] Creating container runtime client: Docker
[lumogon] 2017/05/24 18:28:57.135309 [Scheduler] Creating scheduler
[lumogon] 2017/05/24 18:28:57.135332 [Docker Adapter] Creating container runtime client: Docker
[lumogon] 2017/05/24 18:28:57.135342 [Scheduler] Running
[lumogon] 2017/05/24 18:28:57.135346 [Scheduler] Creating context with timeout [60]
[lumogon] 2017/05/24 18:28:57.135416 [Analytics] Skipping submission of Google Analytics event

We need to test this in E2E once we get those up and going.

johnmccabe commented 7 years ago

@jfryman I'll 🚢 when green

tylerpace commented 7 years ago

👍