(MAINT) Use Docker build stages to compose image

puppetlabs-toy-chest / lumogon

Get a complete picture of what your applications are made of *without* changing how you currently build and run containers. Just run and report.

Other

198 stars 14 forks source link

(MAINT) Use Docker build stages to compose image #44

Closed johnmccabe closed 7 years ago

johnmccabe commented 7 years ago

This PR uses the build stages feature to build the client and subsequent image from the same Dockerfile.

It requires the use of the current edge release 17.05.

garethr commented 7 years ago

I'm a big +1 on merging this, just checking with @jfryman, @tylerpace and @kenazk that you have 17.05 and don't see this as a problem.

jfryman commented 7 years ago

LGTM :+1:.

I run 17.05.0-ce.

johnmccabe commented 7 years ago

If/when Docker Hub supports multi-stage builds then this is gonna be awesome to enable switching to an automated hub build rather than the Travis image push - if that happens.

johnmccabe commented 7 years ago

ping @tylerpace / @kenazk

tylerpace commented 7 years ago

👍

johnmccabe commented 7 years ago

@puppetlabs/lumogon can I get this merged when green please