(maint) Update adding deploy rsa key via Gitea API

[donoghuc]

Version: learning_puppet_vm-6.5 Public key extension does not contain .rsa when generated as described in quest. To reproduce: ssh-keygen -t rsa -b 4096 -C "learning@puppet.vm"

ls /etc/puppetlabs/puppetserver/ssh/
id-control_repo  id-control_repo.pub

[greglarkin]

Thank you for the PR @donoghuc! Can you take a look at the RSA key (private and public) key names throughout the quests where they are used? Based on some recent user reports and my own testing, there are some other inconsistencies in the naming that can trip people up.

[donoghuc]

How are the spec tests run? From version 6.5 I tried a few variations of the invocation below along with running ruby tests/scripts/setup [quest name] but was unsuccessful.

[/usr/src/puppet-quest-guide]
root@learning: # rspec tests

I am running version 6.5 which does not have all the updates from master branch. How can I get a more up to date copy or build from master? I ask because for this version the Gitea for the 6.5 does not have a patch (https://github.com/go-gitea/gitea/pull/3133) that results in 404 when creating pull request in the gui.

[/home/git/go/bin]
root@learning: # ./gitea --version
Gitea version 1.1.0+dev

As a puppet newcomer I have found the learning VM to be incredibly helpful!

[greglarkin]

@donoghuc My apologies for the delay - the spec tests are run continuously by the quest tool (https://github.com/puppetlabs/quest). There are some details in that project README for how that works. As far as I know, the spec tests are not designed to be run by hand, but I'm not 100% sure.

In order to build the Learning VM yourself, you will also need to clone the https://github.com/puppetlabs/education-builds/ repository. Once you have that, I believe you can run the following commands in it:

rake build_base['learning']
rake build_main['learning']

This will take a very long time, and the output should be an OVA file. I'm just getting reacquainted with LVM development, so if I learn anything else helpful, I will let you know.

[greglarkin]

Hi @donoghuc I'm going to close this PR since I decided to keep the .rsa extension and fix the original key filename in the quest. Everything should now be consistent with the .rsa extension in place.

This was a tiny bit easier to do this way since it avoided having to take a new PE console screenshot that also shows the private key filename with the .rsa extension. There are a bunch of changes to the quests for PE 2019, and an updated version will be released in the near future.