search

puppetlabs-toy-chest / puppetlabs-aws

Puppet module for managing AWS resources to build out infrastructure
Apache License 2.0
188 stars 216 forks source link

Begin filtering sensitive data during VCR recording #395

Closed prozach closed 7 years ago

prozach commented 7 years ago

Without this change, module testers are left to their own methods to ensure that they are not leaking any sensitive material when contributing to this module. This is not good, as a) we want more tests and b) we would like not to expose data from contributor environments when submitting changes.

Here we take a stab addressing this concern by configuring VCR to filter out the AWS_ACCESS_KEY_ID. This alone is not enough to be complete, but it begins the road of making testing simpler on the part of those who wish to contribute to the module. Now we can amend the documentation to include information about exporting the necessary environment variables, not providers specs don't have to modified last minute to avoid committing credentials.

prozach commented 7 years ago

https://github.com/puppetlabs/puppetlabs-aws/issues/333

prozach commented 7 years ago

I believe these tests should pass after https://github.com/puppetlabs/puppetlabs-aws/pull/397 is merged and a rebase is done here.

hunner commented 7 years ago

Rebase away!

prozach commented 7 years ago

Rebased and updated the tests for the recently merged iam_ types and providers.