puppetlabs-toy-chest / puppetlabs-package_updates

Package update discovery Puppet Face and custom Facter fact
12 stars 6 forks source link

Null value in "/opt/puppetlabs/facter/facts.d/package_updates.json" #26

Open papseddy opened 6 years ago

papseddy commented 6 years ago

Hi,

After few run of cron, /opt/puppetlabs/puppet/bin/puppet package updates --render-as json command put NULL in "/opt/puppetlabs/facter/facts.d/package_updates.json" file and after then whenever puppet agent runs it show error.

[root@agent-2 ~]# puppet agent -t Error: Facter: error while processing "/opt/puppetlabs/facter/facts.d/package_updates.json" for external facts: The document root must not follow by other values. Info: Using configured environment 'production' Info: Retrieving pluginfacts Info: Retrieving plugin Info: Retrieving locales Info: Loading facts Error: Facter: error while processing "/opt/puppetlabs/facter/facts.d/package_updates.json" for external facts: The document root must not follow by other values. Info: Caching catalog for agent-2.example.com Info: Applying configuration version '1520410771' Notice: /Stage[main]/Package_updates/Exec[package_updates]/returns: executed successfully Notice: Applied catalog in 110.52 seconds

Is this any problem or i am doing something wrong.

gordonmessmer commented 6 years ago

I think this patch fixes the problem: https://github.com/puppetlabs/puppetlabs-package_updates/pull/28