puppetlabs-toy-chest / puppetlabs-puppetserver_gem

This module provides management of Ruby gems for Puppet Server.
3 stars 24 forks source link

proxy server support by ensuring `$HOME` is set #18

Closed GeoffWilliams closed 7 years ago

GeoffWilliams commented 7 years ago

ensure that the HOME component of the environment is passed through to the puppetserver script to enable access to proxy server settings that are usually in /root/.gemrc

This fixes #8 -- @robbyt thanks for your bug report, I had the exact same problem and this made the fix a lot easier.

justinstoller commented 7 years ago

I was wondering, on recent versions of gem you can pass --proxy-host URL to the install command as a flag. The package provider should support install_options parameter. Was that attempted and why didn't that work?

GeoffWilliams commented 7 years ago

didn't attempt either of these options. The nice thing about the .gemrc file is that it fixes the command once and for all, for every invocation. Passing --proxy-host and install_options would only work when driven by puppet. Also, since $HOME isn't set, the system will always try to read a configuration file from a place it shouldn't (/.gemrc from memory) and this may also have other side effects, although I didn't investigate these

justinstoller commented 7 years ago

Cool. Just trying to understand how folks are using this. I've pinged @eputnam since the modules team owns this module. I'm sure he can help work with you to get this improvement merged in.