search

puppetlabs-toy-chest / wash

Wide Area SHell: a cloud-native shell for bringing remote infrastructure to your terminal.
https://puppetlabs.github.io/wash
Apache License 2.0
180 stars 29 forks source link

Fix Wash regressions #637

Closed MikaelSmith closed 4 years ago

MikaelSmith commented 4 years ago

Fix regressions introduced by #635. Supports #297.

MikaelSmith commented 4 years ago

There's one more issue I'm investigating with zsh

zsh: can't set tty pgrp: operation not permitted

One difference I've found is that running go run wash.go starts with Wash in the go run ... process group, and when zsh exits it returns the tty to that process group. Where-as starting wash, it starts in its own process group which gets reparented to be under the zsh session, so trying to return the tty to the parent process group fails because you're not allowed to switch control that direction.

MikaelSmith commented 4 years ago

Updated.