search

puppetlabs-toy-chest / wash

Wide Area SHell: a cloud-native shell for bringing remote infrastructure to your terminal.
https://puppetlabs.github.io/wash
Apache License 2.0
180 stars 29 forks source link

Support block-readable entries #638

Closed ekinanp closed 4 years ago

ekinanp commented 4 years ago

External plugins will be handled in a follow-up PR. We should also file a separate issue for the volume package; I didn't implement BlockReadable for the volume package because it isn't as easy to do as e.g. S3 objects or GCP storage objects.

Supports https://github.com/puppetlabs/wash/issues/619

ekinanp commented 4 years ago

I'll also look into https://github.com/puppetlabs/wash/issues/609 in a separate PR. Right now, things work as they did before.

ekinanp commented 4 years ago

Updated to ignore io.EOF errors, and to also address the current feedback.

ekinanp commented 4 years ago

Going to add a bit more validation to plugin.Read before merging this.

ekinanp commented 4 years ago

Updated to restore io.EOF and to add some more validation to plugin.Read.