search

puppetlabs-toy-chest / wash

Wide Area SHell: a cloud-native shell for bringing remote infrastructure to your terminal.
https://puppetlabs.github.io/wash
Apache License 2.0
180 stars 29 forks source link

docs command panics on a schema-less entry #704

Closed ekinanp closed 4 years ago

ekinanp commented 4 years ago 
wash . ❯ docs spotify
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0x58fa94d]

goroutine 1 [running]:
github.com/puppetlabs/wash/api/types.(*EntrySchema).Signals(...)
    /Users/enisinan/GitHub/wash/api/types/entrySchema.go:210
github.com/puppetlabs/wash/cmd.docsMain(0xc0002d2c80, 0xc00041f9a0, 0x1, 0x1, 0xc0000ba720)
    /Users/enisinan/GitHub/wash/cmd/docs.go:89 +0x2fd
github.com/puppetlabs/wash/cmd.toRunE.func1(0xc0002d2c80, 0xc00041f9a0, 0x1, 0x1, 0x4, 0x450c7b0)
    /Users/enisinan/GitHub/wash/cmd/root.go:36 +0x4d
github.com/puppetlabs/wash/cmd.ensureGARegistration.func4(0xc0002d2c80, 0xc00041f9a0, 0x1, 0x1, 0x0, 0x0)
    /Users/enisinan/GitHub/wash/cmd/root.go:104 +0x8b
github.com/spf13/cobra.(*Command).execute(0xc0002d2c80, 0xc00041f970, 0x1, 0x1, 0xc0002d2c80, 0xc00041f970)
    /Users/enisinan/go/pkg/mod/github.com/spf13/cobra@v0.0.5/command.go:826 +0x460
github.com/spf13/cobra.(*Command).ExecuteC(0xc0003d6500, 0x0, 0xc0005d9f50, 0x40071bf)
    /Users/enisinan/go/pkg/mod/github.com/spf13/cobra@v0.0.5/command.go:914 +0x2fb
github.com/spf13/cobra.(*Command).Execute(...)
    /Users/enisinan/go/pkg/mod/github.com/spf13/cobra@v0.0.5/command.go:864
github.com/puppetlabs/wash/cmd.Execute(0xc0000ba058)
    /Users/enisinan/GitHub/wash/cmd/root.go:180 +0x9e
main.main()
    /Users/enisinan/GitHub/wash/wash.go:13 +0x22

This is also due to a missing nil-pointer check