puppetlabs-toy-chest / wash

Wide Area SHell: a cloud-native shell for bringing remote infrastructure to your terminal.
https://puppetlabs.github.io/wash
Apache License 2.0
180 stars 29 forks source link

gvfsd-fuse process and mounted filesystem leftover after exiting #718

Open suckatrash opened 4 years ago

suckatrash commented 4 years ago

Describe the Bug

In Ubuntu 18.04.4 after exiting the shell there is a gvfsd-fuse process and mounted filesystem left mounted. Normally this is fine and if a new instance of wash starts it will re-use the process / mount. However if wash exits abnormally this can create multiple zombie processes / mounts and an inability to start the shell.

Expected Behavior

Wash should cleanup these resources when it exits, or check for their existence when starting.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Start wash
  2. Run pkill wash or similar
  3. The shell fails to initialize, if you kill the process again you will see multiple mounts left over:
    gvfsd-fuse on /run/user/1000/gvfs type fuse.gvfsd-fuse (rw,nosuid,nodev,relatime,user_id=1000,group_id=1000)
    /dev/fuse on /home/user/.cache/wash/mnt014415005 type fuse (rw,nosuid,nodev,relatime,user_id=1000,group_id=1000)
    /dev/fuse on /home/user/.cache/wash/mnt454964253 type fuse (rw,nosuid,nodev,relatime,user_id=1000,group_id=1000)

Environment

welcome[bot] commented 4 years ago

Thanks for opening your first issue here! We will follow up as soon as we can.