Improve reporting on non-zero exit for fs List

puppetlabs-toy-chest / wash

Wide Area SHell: a cloud-native shell for bringing remote infrastructure to your terminal.

https://puppetlabs.github.io/wash

Apache License 2.0

180 stars 29 forks source link

Improve reporting on non-zero exit for fs List #748

Closed MikaelSmith closed 4 years ago

MikaelSmith commented 4 years ago

Some non-zero exits are normal with find (see examples in code). The messages that caused this can appear on stdout or stderr depending on whether a tty is used or if it's a stat executed by find. Ignore normal failures, but if we get an unknown one fail VolumeList and return the error.

Fixes #742.

Signed-off-by: Michael Smith michael.smith@puppet.com

MikaelSmith commented 4 years ago

Changed it slightly because sometimes stat: and find: messages appear on stderr, and that caused the docker tests to fail.