puppetlabs-toy-chest / wash

Wide Area SHell: a cloud-native shell for bringing remote infrastructure to your terminal.

https://puppetlabs.github.io/wash

Apache License 2.0

180 stars 29 forks source link

Implement exec on Directories #772

Open sbrow opened 4 years ago

sbrow commented 4 years ago

As discussed in issue #769. This is still a work in progress.

Todos:

[ ] Write tests
[ ] Implement in plugins other than docker.
[ ] Add option to enable in volume.NewFS?
[x] Update entrySchema on execDir.

welcome[bot] commented 4 years ago

Hi! 💖 Thanks for your contribution 🎉🥳

We'll get it reviewed as soon as possible. If you'd like to chat with the developers, the #puppet-dev channel on Slack would probably be a great place to start. Make sure that your commit messages fit our contribution standards to make the code review go quickly.

If this is your first contribution to our repositories, then we'd love to send you a small welcome gift 🎁. Drop us a line at community@puppet.com and let us know where to send it! (/cc @puppetlabs/community)

MikaelSmith commented 4 years ago

That looks pretty straightforward, although it looks like some test mocking needs to be tweaked.

CLAassistant commented 3 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}