puppetlabs / beaker-puppet

Beaker's puppet-specific helper library
Apache License 2.0
4 stars 66 forks source link

Beaker 5 compatibility #240

Closed mhashizume closed 8 months ago

mhashizume commented 8 months ago

This PR adds Beaker 5 compatibility by dropping Beaker 4-specific code and updating the gemspec.

This PR supercedes https://github.com/puppetlabs/beaker-puppet/pull/216

mhashizume commented 8 months ago

Passing ad hoc agent pipeline with Beaker 5: https://jenkins-platform.delivery.puppetlabs.net/view/puppet-agent/view/ad-hoc/job/platform_puppet-agent-extra_puppet-agent-integration-suite_adhoc-ad_hoc/1291/

bastelfreak commented 8 months ago

I want to repeat what I'm saying since 2017: I think it was a huge design mistake that Puppet made the Jenkins private but still has public repos that depend on pipelines on that specific Jenkins. That excludes all outside collaborators from properly reviewing PRs.