search

puppetlabs / best-practices

Best practice docs created by the Puppet Customer Success team
Apache License 2.0
119 stars 47 forks source link

Environment definition too vague #17

Closed ghost closed 5 years ago

ghost commented 5 years ago

https://github.com/puppetlabs/best-practices/blob/9dab8034b10c52ea2156391a8cf1ba4d6aa5905f/use-of-environment-in-hiera-hierarchy.md defines a puppet environment as, "A directory on the master containing Puppet code." That means that ../my_mod/manifests and ../my_mod/manifests/other_puppet_code are separate environments and clearly that isn't what was desired. If I am missing something I'd like to know what simply for the purposes of educating myself. Otherwise maybe the definition could be made more specific.

suhailc commented 5 years ago

Hi,

But actually you can specify any directory in the hierarchy.yaml so it is correct that it is not more specific. Of course it is assumed that the reader is familiar enough with puppet to know that the manifests folder is not what you specify in hierarchy.yaml

Regards, Suhail.

On Tue, 30 Oct 2018, 18:05 Jonas Steinberg, notifications@github.com wrote:

https://github.com/puppetlabs/best-practices/blob/9dab8034b10c52ea2156391a8cf1ba4d6aa5905f/use-of-environment-in-hiera-hierarchy.md defines a puppet environment as, "A directory on the master containing Puppet code." That means that ../my_mod/manifests and ../my_mod/manifests/other_puppet_code are separate environments and clearly that isn't what was desired. If I am missing something I'd like to know what simply for the purposes of educating myself. Otherwise maybe the definition could be made more specific.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/puppetlabs/best-practices/issues/17, or mute the thread https://github.com/notifications/unsubscribe-auth/ACkV7U6i3ooE02GjNm86UuJNNuZH8xDRks5uqJTkgaJpZM4YChWx .

ghost commented 5 years ago

Okay. I figured that the definition was being used more in the context of newer Puppet which presumes the use of Hiera. Thanks.