search

puppetlabs / best-practices

Best practice docs created by the Puppet Customer Success team
Apache License 2.0
119 stars 47 forks source link

Add best practice around recursive file resources #7

Closed npwalker closed 6 years ago

natemccurdy commented 6 years ago

I'm 👍 on this, but I chose not to merge it because I'm curious if anyone else has any other general advice around recurse => true. Other examples, other use cases, or other alternatives.

reidmv commented 6 years ago

@npwalker made some edits, mainly to include reference to when it's ok to use recurse => true. Please review. Thanks!

natemccurdy commented 6 years ago

@npwalker Did you mean to include the template file in this PR?

Also, I'm happy with @reidmv 's changes and will merge this unless I hear any other feedback soon.

npwalker commented 6 years ago

@natemccurdy yes we should have a template here I think and this was my first PR trying to make something in here so I included the template.

I went ahead and squashed this down to 2 commits.