puppetlabs / bolt-vanagon

Apache License 2.0
2 stars 30 forks source link

(BOLT-126) Upgrade winrm gem to 2.3.2 #100

Closed Iristyle closed 5 years ago

Iristyle commented 5 years ago

Artifact is already published in Artifactory at:

https://artifactory.delivery.puppetlabs.net/artifactory/webapp/#/artifacts/browse/tree/General/rubygems__remote-cache/gems/winrm-2.3.2.gem

donoghuc commented 5 years ago

This ended up in bolt-runtime https://github.com/puppetlabs/puppet-runtime/pull/169

Iristyle commented 5 years ago

Is there a reason to not also include it here? It's unclear to me why we have Vanagon metadata if this package won't use the dependency? (i.e. should we delete the winrm files from this repo?)

On Thu, May 9, 2019, 1:28 PM Cas Donoghue notifications@github.com wrote:

This ended up in bolt-runtime puppetlabs/puppet-runtime#169 https://github.com/puppetlabs/puppet-runtime/pull/169

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/puppetlabs/bolt-vanagon/pull/100#issuecomment-490994380, or mute the thread https://github.com/notifications/unsubscribe-auth/AADAGYK3ILGMPY6FNO3JKZLPURNMJANCNFSM4HLCIOCA .

donoghuc commented 5 years ago

@Iristyle we deleted all the gem component definitions from bolt-vanagon and instead manage them in the puppet-runtime project. That was merged today https://github.com/puppetlabs/bolt-vanagon/commit/413f9d49a6b14b3be8ee3436f1f6ee78866986e0 are there other files we need to delete from this repo?