puppetlabs / bolt-vanagon

Apache License 2.0
2 stars 31 forks source link

(maint) Move to bolt.bat #149

Closed jpogran closed 3 years ago

jpogran commented 3 years ago

Migrate Bolt to bolt.bat from a PowerShell function

Creates the files used in https://github.com/puppetlabs/bolt/pull/2532

Closes https://github.com/puppetlabs/bolt/issues/2551

Acceptance Criteria:

After building with vanagon,

  1. Install the new MSI
  2. Remove the bolt function declaration from C:\Program Files\WindowsPowerShell\Modules\PuppetBolt\PuppetBolt.psm1 (this is removed in https://github.com/puppetlabs/bolt/pull/2532 but won't be pulled in this PR)

The verify the following:

Note: Any problems with argument parsing should be logged in https://github.com/puppetlabs/bolt/pull/2532

beechtom commented 3 years ago

Built a MSI from https://github.com/jpogran/bolt/tree/boltbat and installed on Windows 2019.

lucywyman commented 3 years ago

I made a 3.0 branch if you want to target that and we can merge, or it's also perfectly fine to just leave this open until we're ready to merge all the 3.0 branches into main.

jpogran commented 3 years ago

rebased the 3.0 branch to be even with main, then rebased this so all commits lined up. this should be good to merge into 3.0

jpogran commented 3 years ago

Since #2551 merged, rebased 3.0 and this branch so this is ready to merge