puppetlabs / bolt-vanagon

Apache License 2.0
2 stars 30 forks source link

(maint) Create bootsnap cache on install #156

Closed jpogran closed 3 years ago

jpogran commented 3 years ago

Acceptance Criteria

beechtom commented 3 years ago

Tested a build with these changes and confirmed that the bootsnap cache is created correctly. I'm noticing some significant impacts to performance, though:

Bolt 3.9.0

measure-command { invoke-bolttask -name facts -t localhost }

Days              : 0
Hours             : 0
Minutes           : 0
Seconds           : 10
Milliseconds      : 44
Ticks             : 100445377
TotalDays         : 0.00011625622337963
TotalHours        : 0.00279014936111111
TotalMinutes      : 0.167408961666667
TotalSeconds      : 10.0445377
TotalMilliseconds : 10044.5377

Bolt with Bootsnap & Puppet 7.7.0

measure-command { invoke-bolttask -name facts -t localhost }

Days              : 0
Hours             : 0
Minutes           : 0
Seconds           : 15
Milliseconds      : 563
Ticks             : 155638889
TotalDays         : 0.000180137603009259
TotalHours        : 0.00432330247222222
TotalMinutes      : 0.259398148333333
TotalSeconds      : 15.5638889
TotalMilliseconds : 15563.8889
CLAassistant commented 3 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: lucywyman
:x: jpogran
You have signed the CLA already but the status is still pending? Let us recheck it.

lucywyman commented 3 years ago

Closing in favor of #171