(GH-2550) Do not ship with PuppetBolt PowerShell module

puppetlabs / bolt-vanagon

Apache License 2.0

2 stars 31 forks source link

(GH-2550) Do not ship with PuppetBolt PowerShell module #164

Open beechtom opened 3 years ago

beechtom commented 3 years ago

This updates the Windows MSI build to not install the PuppetBolt PowerShell module. Users should now install the PuppetBolt PowerShell module through the PowerShell Gallery.

beechtom commented 3 years ago

Built the MSI and installed on a Windows 10 Ent VM. Confirmed that the MSI does not install the PowerShell module.

beechtom commented 3 years ago

Also confirmed that upgrading Bolt successfully removes the PuppetBolt module installed with older MSIs.

lucywyman commented 3 years ago

Note: Since this is a breaking change and we've pretty well missed the boat on Bolt 3.0, we're going to add a deprecation warning to the MSI when the module is imported telling users to install the module themselves from PowerShell Gallery, and add documentation telling users to do so as well. We'll wait until Bolt 4.0 to merge this.

CLAassistant commented 3 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}