(BOLT-650) Add pe-bolt-service to bolt vanagon packaging

[lucywyman]

This adds the pe-bolt-service package to the bolt vanagon project so that we can create pe-bolt-service packages for users to download and install. Relates to the service added by https://github.com/puppetlabs/bolt/pull/503

[mwaggett]

Have you tried building this? I think I would be more helpful if I knew of specific issues you were encountering. (you can run test builds with the dynamic vanagon builder)

[lucywyman]

Oh snap, did not know about dynamic vanagon builder. Thank you!

[stahnma]

Why have this separate and not just part of bolt (e.g. same package?)

[shrug]

But yeah it seems like we should make a single package and just have a service (default to off) that can be toggled on?

[lucywyman]

@stahnma @shrug The main reason we have these as separate packages is so that we can keep their release cadences separate. In the short term this is so we can release bolt-server more quickly for the Console team to develop the Orchestrator client, but I'm not sure what the long term release cadences for both tools will look like, especially when we release Bolt 1.0. I'm not sure how compelling a reason that is to keep them separate? I'll discuss with the rest of the bolt team later this morning as well and see if there are any other concerns one way or another.

Also sorry for going radio silent last night -- I had a headache and headed home :P Thanks for taking the time to look at this!!

Update Discussed with the Bolt team, and we definitely want this to be separate package long term. The main long-term reason is so we don't tie PE users to a specific bolt version, and allow them to use any version of bolt with the bolt-server.

[lucywyman]

Green runs at least: http://jenkins-release.delivery.puppetlabs.net/job/vanagon_generic_job/1680/

[MikaelSmith]

A simple build puppet-bolt el-7-x86_64 still fails for me with

cd bolt && \
/opt/puppetlabs/bolt/bin/gem install --no-rdoc --no-ri --local --bindir=/opt/puppetlabs/bolt/bin bolt-*.gem && \
install -d '/opt/puppetlabs/bin' && \
cp -p '../bolt_env_wrapper' '/opt/puppetlabs/bin/bolt' && \
chmod 0755 '/opt/puppetlabs/bin/bolt' && \
install -d '/usr/local/bin' && \
([[ '/usr/local/bin/bolt' -ef '/opt/puppetlabs/bin/bolt' ]] || ln -s '/opt/puppetlabs/bin/bolt' '/usr/local/bin/bolt')
ERROR:  Could not find a valid gem 'CFPropertyList' (~> 2.2) in any repository
make: *** [bolt-install] Error 2

[lucywyman]

It looks like having it in between the other 2 component calls is what works. I'm not sure if that's weird-looking enough that we should just put that code in both files and ditch the shared file?

[MikaelSmith]

I don't think it's weird.