search

puppetlabs / bolt-vanagon

Apache License 2.0
2 stars 31 forks source link

(maint) Properly install bolt services on systems with sysv init #69

Closed lucywyman closed 5 years ago

lucywyman commented 5 years ago

There's a missing argument to install_service which should be nil that's causing systemv installs of pe-bolt-services to fail

nicklewis commented 5 years ago

The subject line of the commit message should be updated to describe the purpose of the commit. Right now it drastically undersells the significance of the change. Properly install bolt services on systems with sysv init or something would work.

nicklewis commented 5 years ago

There's another EL 6 problem, which is that we universally setup a postinstall action to systemctl daemon-reload, which we should actually only do on systemd platforms.

nicklewis commented 5 years ago

We don't appear to do the systemctl daemon-reload for puppet-agent... why is that necessary here?

lucywyman commented 5 years ago

@nicklewis Got this working on centos6: u5l79hmiqfxft0k.delivery.puppetlabs.net - about to test systemd as well

lucywyman commented 5 years ago

Ok, and verified it still works for systemd as well: re1kwnx9uefs7uf.delivery.puppetlabs.net