search

puppetlabs / bolt-vanagon

Apache License 2.0
2 stars 31 forks source link

(maint) Add ffi and minitar to shared project #75

Closed donoghuc closed 5 years ago

donoghuc commented 5 years ago

Acceptable versions of ffi and minitar have been added to the puppet-runtime project. This commit adds those to the project definition shared by puppet-bolt and pe-bolt-server.

MikaelSmith commented 5 years ago

I'm not sure why this makes sense. Shouldn't they just be part of the runtime? We shouldn't have to call them out explicitly.

MikaelSmith commented 5 years ago

Wouldn't this require adding back the component configs?

MikaelSmith commented 5 years ago

I suspect the problem is really that the puppet-agent version pe-bolt-server installs against doesn't have the updated runtime with ffi and minitar.

donoghuc commented 5 years ago

I see so the line https://github.com/puppetlabs/bolt-vanagon/blob/476379c72fcde9c0b5f31820cf0fa9dbf713dcfb/configs/projects/pe-bolt-server.rb#L3 requires puppet-agent which means that the packages in the corresponding agent-runtime https://github.com/puppetlabs/puppet-runtime/tree/master/configs/projects are available?

MikaelSmith commented 5 years ago

Yeah.