search

puppetlabs / bolt-vanagon

Apache License 2.0
2 stars 30 forks source link

(BOLT-153) Add ruby_smb gem 1.0.5 #80

Closed Iristyle closed 5 years ago

Iristyle commented 5 years ago
Iristyle commented 5 years ago

Approved via https://tickets.puppetlabs.com/browse/RE-12026

donoghuc commented 5 years ago

Looks like we need to also add some dependencies:

cas@cas-ThinkPad-T460p:~/working_dir/bolt$ diff Gemfile-smb_ruby.lock Gemfile-bolt_master.lock
28d27
<       ruby_smb (~> 1.0)
43d41
<     bindata (2.4.4)
186,189d183
<     ruby_smb (1.0.5)
<       bindata
<       rubyntlm
<       windows_error
205d198
<     windows_error (0.1.2)

Specifically bindata (2.4.4) and windows_error (0.1.2). Seems like those licences were reviewed as part of https://tickets.puppetlabs.com/browse/RE-12026

Iristyle commented 5 years ago

Thanks @donoghuc for catching that mistake. PR updated accordingly.

FYI - bindata is BSD 2-Clause and windows_error is BSD 3-Clause like rubysmb. We already had a dependency on rubyntlm.

Iristyle commented 5 years ago

@donoghuc updated component names as requested