search

puppetlabs / bolt-vanagon

Apache License 2.0
2 stars 31 forks source link

(ORCH-2296) Load shared gems from puppet-runtime #99

Closed caseywilliams closed 5 years ago

caseywilliams commented 5 years ago

There are two commits here:

The first fixes a bug:

    (ORCH-2295) Remove postinstall actions for plan executor service

    These calls to chown were forgotten in b1903d1 -- they were attempting
    to chown nonexistent directories for the old plan executor service,
    producing errors on installation of pe-bolt-server.

The second begins work for ORCH-2296:


    (ORCH-2296) Source shared gems from puppet-runtime

    In preparation for the separation of pe-bolt-server project into its own
    dedicated repo as part of ORCH-2296, this removes all configuration for
    gems shared between the puppet-bolt and pe-bolt-server projects from
    this repo and loads them from puppet-runtime instead.

    - Gems used only by one of the projects are retained here for now.
    - Subsequent PRs will remove pe-bolt-server and its dependencies from
      this repo and move them to a dedicated PE bolt-vanagon repo instead.

    As part of these changes, the pe-bolt-server begins to use its own
    runtime tarball.

This PR depends on https://github.com/puppetlabs/puppet-runtime/pull/166, and it should not be merged until those changes have built and promoted to this repo.

This is against the johnson branch. I'm planning to apply the same changes to kearney/lovejoy (master) in a subsequent mergeup PR, after this has passed CI.

donoghuc commented 5 years ago

Pulled in these changes to my fork (https://github.com/puppetlabs/bolt-vanagon/compare/master...donoghuc:test-puppet-runtime?expand=1) and build based off experimental run of https://github.com/puppetlabs/puppet-runtime/pull/166#issuecomment-488517620 . https://jenkins-master-prod-1.delivery.puppetlabs.net/view/__experimental%20automatic/job/experimental_auto_bolt-vanagon_vanagon-packaging_no-PEZ-daily-master/ is all green.

I think adding everything to puppet runtime vanagon is brilliant. Will look deeper at the code tomorrow. Very nice work.

caseywilliams commented 5 years ago

Here are successful builds of pe-bolt-server and puppet-bolt using these changes and the corresponding puppet-runtime PR.

caseywilliams commented 5 years ago

The puppet-runtime changes supporting this PR have been merged, built, and promoted to this repo's bolt-runtime component. I think this is ready to go.