search

puppetlabs / cat-github-actions

1 stars 4 forks source link

(maint) - Update gem_release_prep.yml #21

Closed jordanbreen28 closed 1 year ago

jordanbreen28 commented 1 year ago

Prior to this PR, the gem release prep workflow required the verion.rb file to be in ./lib/$gem_name/version.rb. This was determined to not be suitable, as not all gems followed this folder structure.

This PR introduces a better method, that will work for all of the gems that will use this workflow. As long as the version.rb file lives as a file or within a subdirectory of the './lib/' directory, the workflow will update the version.rb file.

jordanbreen28 commented 1 year ago

Examples of passing runs:

  1. Gem that follows /lib/$gem_name/version.rb https://github.com/puppetlabs/puppet_litmus/pull/476
  2. Gem that doesn't follow /lib/$gem_name/version.rb folder structure https://github.com/puppetlabs/puppet-lint-check_unsafe_interpolations/pull/40